From 1d4b230417184dfbc5e21f106589b9538d42b026 Mon Sep 17 00:00:00 2001 From: Franck Allimant Date: Fri, 14 Mar 2014 15:03:04 +0100 Subject: [PATCH 1/2] Improves error messages in image and document loop --- core/lib/Thelia/Core/Template/Loop/Document.php | 2 +- core/lib/Thelia/Core/Template/Loop/Image.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/lib/Thelia/Core/Template/Loop/Document.php b/core/lib/Thelia/Core/Template/Loop/Document.php index 0353b8df6..e681c9c93 100644 --- a/core/lib/Thelia/Core/Template/Loop/Document.php +++ b/core/lib/Thelia/Core/Template/Loop/Document.php @@ -262,7 +262,7 @@ class Document extends BaseI18nLoop implements PropelSearchLoopInterface $loopResult->addRow($loopResultRow); } catch (\Exception $ex) { // Ignore the result and log an error - Tlog::getInstance()->addError(sprintf("Failed to process document in document loop: %s", $ex->getMessage()), $this->args); + Tlog::getInstance()->addError("Failed to process document in document loop: ", $ex->getMessage(), ", loop arguments: ", $this->args); } } diff --git a/core/lib/Thelia/Core/Template/Loop/Image.php b/core/lib/Thelia/Core/Template/Loop/Image.php index 157259f30..3c21627a7 100644 --- a/core/lib/Thelia/Core/Template/Loop/Image.php +++ b/core/lib/Thelia/Core/Template/Loop/Image.php @@ -316,7 +316,7 @@ class Image extends BaseI18nLoop implements PropelSearchLoopInterface $loopResult->addRow($loopResultRow); } catch (\Exception $ex) { // Ignore the result and log an error - Tlog::getInstance()->addError("Failed to process image in image loop: ", $this->args); + Tlog::getInstance()->addError("Failed to process image in image loop: ", $ex->getMessage(), ", loop arguments: ", $this->args); } } From ac4b92949b7dcb46a35bdfc848acd40da58f8ebe Mon Sep 17 00:00:00 2001 From: Franck Allimant Date: Fri, 14 Mar 2014 15:53:21 +0100 Subject: [PATCH 2/2] Improved (again) error messages --- core/lib/Thelia/Core/Template/Loop/Document.php | 2 +- core/lib/Thelia/Core/Template/Loop/Image.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/lib/Thelia/Core/Template/Loop/Document.php b/core/lib/Thelia/Core/Template/Loop/Document.php index e681c9c93..6f68c9aa0 100644 --- a/core/lib/Thelia/Core/Template/Loop/Document.php +++ b/core/lib/Thelia/Core/Template/Loop/Document.php @@ -262,7 +262,7 @@ class Document extends BaseI18nLoop implements PropelSearchLoopInterface $loopResult->addRow($loopResultRow); } catch (\Exception $ex) { // Ignore the result and log an error - Tlog::getInstance()->addError("Failed to process document in document loop: ", $ex->getMessage(), ", loop arguments: ", $this->args); + Tlog::getInstance()->addError(sprintf("Failed to process document in document loop: %s", $ex->getMessage())); } } diff --git a/core/lib/Thelia/Core/Template/Loop/Image.php b/core/lib/Thelia/Core/Template/Loop/Image.php index 3c21627a7..c015d2f44 100644 --- a/core/lib/Thelia/Core/Template/Loop/Image.php +++ b/core/lib/Thelia/Core/Template/Loop/Image.php @@ -316,7 +316,7 @@ class Image extends BaseI18nLoop implements PropelSearchLoopInterface $loopResult->addRow($loopResultRow); } catch (\Exception $ex) { // Ignore the result and log an error - Tlog::getInstance()->addError("Failed to process image in image loop: ", $ex->getMessage(), ", loop arguments: ", $this->args); + Tlog::getInstance()->addError(sprintf("Failed to process image in image loop: %s", $ex->getMessage())); } }