From 98a21c72c579223368e3442f79408be5c21a54ae Mon Sep 17 00:00:00 2001 From: Etienne Roudeix Date: Wed, 15 Jan 2014 12:26:46 +0100 Subject: [PATCH] fix empty argument in loop issue --- core/lib/Thelia/Core/Template/Element/BaseLoop.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/core/lib/Thelia/Core/Template/Element/BaseLoop.php b/core/lib/Thelia/Core/Template/Element/BaseLoop.php index db61c20c1..bdf605f79 100755 --- a/core/lib/Thelia/Core/Template/Element/BaseLoop.php +++ b/core/lib/Thelia/Core/Template/Element/BaseLoop.php @@ -178,10 +178,12 @@ abstract class BaseLoop if ($value === null && $argument->mandatory) { $faultActor[] = $argument->name; $faultDetails[] = sprintf('"%s" parameter is missing in loop type: %s, name: %s', $argument->name, $loopType, $loopName); - } else if ($value === '' && !$argument->empty) { - /* check if empty */ - $faultActor[] = $argument->name; - $faultDetails[] = sprintf('"%s" parameter cannot be empty in loop type: %s, name: %s', $argument->name, $loopType, $loopName); + } else if ($value === '') { + if(!$argument->empty) { + /* check if empty */ + $faultActor[] = $argument->name; + $faultDetails[] = sprintf('"%s" parameter cannot be empty in loop type: %s, name: %s', $argument->name, $loopType, $loopName); + } } elseif ($value !== null && !$argument->type->isValid($value)) { /* check type */ $faultActor[] = $argument->name;