remove fixme comment when not needed anymore

core/bootstrap.php

@@ -21,7 +21,6 @@ if (!file_exists(THELIA_CONF_DIR . 'database.yml') && !defined('THELIA_INSTALL_M
         define('THELIA_INSTALL_MODE', true);
     } else {
         $request = \Thelia\Core\HttpFoundation\Request::createFromGlobals();
-        header('location: '.$request->getUriForPath() . '/install');
+        header('location: '.$request->getUriForPath('/install'));
-        exit;
     }
 }

core/lib/Thelia/Command/GenerateResources.php

@@ -61,8 +61,7 @@ class GenerateResources extends ContainerAwareCommand
         $constants = $class->getConstants();
 
         if (count($constants) == 0) {
-            $output->writeln('No resources found');
+            throw new \RuntimeException('No resources found');
-            exit;
         }
 
         switch ($input->getOption("output")) {

core/lib/Thelia/Command/Install.php

@@ -163,11 +163,7 @@ class Install extends ContainerAwareCommand
         }
 
         if (false === $isValid) {
-            $output->writeln(array(
+            throw new \RuntimeException('Please put correct permissions and reload install process');
-                "",
-                "<error>Please put correct permissions and reload install process</error>"
-            ));
-            exit;
         }
     }
 

core/lib/Thelia/Controller/Admin/AbstractCrudController.php

@@ -449,7 +449,6 @@ abstract class AbstractCrudController extends BaseAdminController
     /**
      * Update object position (only for objects whichsupport that)
      *
-     * FIXME: integrate with genericUpdatePositionAction
      */
     public function updatePositionAction()
     {

core/lib/Thelia/Controller/Admin/SessionController.php

@@ -122,7 +122,7 @@ class SessionController extends BaseAdminController
             $this->applyUserLocale($user);
 
             /**
-             * FIXME: we have tou find a way to send cookie
+             * we have tou find a way to send cookie
              */
             if (intval($adminLoginForm->getForm()->get('remember_me')->getData()) > 0) {
                 // If a remember me field if present and set in the form, create

core/lib/Thelia/Core/Template/Assets/AsseticAssetManager.php

@@ -171,16 +171,6 @@ class AsseticAssetManager implements AssetManagerInterface
 
             $fs = new Filesystem();
 
-            // FIXME: locking or not locking ?
-            /*
-                        $lock_file = "$web_assets_directory_base/assets-".md5($source_assets_directory)."-generation-lock.txt";
-
-                        if (! $fp = fopen($lock_file, "w")) {
-                            throw new IOException(sprintf('Failed to open lock file %s', $lock_file));
-                        }
-
-                        if (flock($fp, LOCK_EX|LOCK_NB)) { // do an exclusive lock
-            */
             $tmp_dir = "$to_directory.tmp";
 
             $fs->remove($tmp_dir);

core/lib/Thelia/Core/Template/Loop/Feed.php

@@ -82,7 +82,7 @@ class Feed extends BaseLoop  implements ArraySearchLoopInterface
                 ->set("TITLE"       , $item->get_title())
                 ->set("AUTHOR"      , $item->get_author())
                 ->set("DESCRIPTION" , $item->get_description())
-                ->set("DATE"        , $item->get_date('U')) // FIXME - date format should be an intl parameter
+                ->set("DATE"        , $item->get_date('U'))
             ;
 
             $loopResult->addRow($loopResultRow);

core/lib/Thelia/Core/TheliaHttpKernel.php

@@ -188,7 +188,6 @@ class TheliaHttpKernel extends HttpKernel
                     // TODO : search if http status 302 is the good one.
                     $redirect = new RedirectResponse($lang->getUrl(), 302);
                     $redirect->send();
-                    exit;
                 } else {
                     //the user is actually on the good domain, nothing to change
                     return null;

core/lib/Thelia/Form/AttributeModificationForm.php

@@ -39,12 +39,6 @@ class AttributeModificationForm extends AttributeCreationForm
                         )
                     )
             ))
-/* FIXME: doesn't work
-            ->add('attribute_values', 'collection', array(
-                    'type'   => 'text',
-                    'options'  => array('required'  => false)
-            ))
-*/
         ;
 
         // Add standard description fields

core/lib/Thelia/Form/FeatureModificationForm.php

@@ -39,13 +39,7 @@ class FeatureModificationForm extends FeatureCreationForm
                         )
                     )
             ))
-/* FIXME: doesn't work
+     ;
-            ->add('feature_values', 'collection', array(
-                    'type'   => 'text',
-                    'options'  => array('required'  => false)
-            ))
-*/
-        ;
 
         // Add standard description fields
         $this->addStandardDescFields();

core/lib/Thelia/Form/TemplateModificationForm.php

@@ -41,18 +41,6 @@ class TemplateModificationForm extends TemplateCreationForm
                         )
                     )
             ))
-/*
-            ->add('attributes', 'collection', array(
-                    'type'   => 'text',
-                    'options'  => array('required'  => false)
-            ))
-*/
-/* FIXME: doesn't work
-            ->add('features', 'collection', array(
-                    'type'   => 'text',
-                    'options'  => array('required'  => false)
-            ))
-*/
             ;
     }
 

core/lib/Thelia/Tools/MoneyFormat.php

@@ -49,7 +49,6 @@ class MoneyFormat extends NumberFormat
         $number = parent::format($number, $decimals, $decPoint, $thousandsSep);
 
         if ($symbol !== null) {
-            // FIXME: should be a parameter related to i18n configuration
             $number = $number . ' ' . $symbol;
         }
 

core/lib/Thelia/Tools/Redirect.php

@@ -35,7 +35,5 @@ class Redirect
 
             $response->send();
         }
-
-        exit;
     }
 }