From f9be7d19637e169a93111a28b7bf00e2ff68c801 Mon Sep 17 00:00:00 2001 From: Franck Allimant Date: Tue, 4 Feb 2014 00:55:02 +0100 Subject: [PATCH] Imporved exception logging --- .../Controller/Admin/ModuleController.php | 20 +++++-------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/core/lib/Thelia/Controller/Admin/ModuleController.php b/core/lib/Thelia/Controller/Admin/ModuleController.php index e86014809..2eedc8f44 100644 --- a/core/lib/Thelia/Controller/Admin/ModuleController.php +++ b/core/lib/Thelia/Controller/Admin/ModuleController.php @@ -31,6 +31,7 @@ use Thelia\Core\Event\Module\ModuleToggleActivationEvent; use Thelia\Core\Event\TheliaEvents; use Thelia\Core\Security\AccessManager; use Thelia\Form\ModuleModificationForm; +use Thelia\Log\Tlog; use Thelia\Model\ModuleQuery; use Thelia\Module\ModuleManagement; use Thelia\Core\Event\UpdatePositionEvent; @@ -56,20 +57,6 @@ class ModuleController extends AbstractCrudController null, null, TheliaEvents::MODULE_UPDATE_POSITION -/* - $objectName, - - $defaultListOrder = null, - $orderRequestParameterName = null, - - $resourceCode, - - $createEventIdentifier, - $updateEventIdentifier, - $deleteEventIdentifier, - $visibilityToggleEventIdentifier = null, - $changePositionEventIdentifier = null -*/ ); } @@ -249,6 +236,8 @@ class ModuleController extends AbstractCrudController } } catch (\Exception $e) { $message = $e->getMessage(); + + Tlog::getInstance()->addError("Failed to activate/deactivate module:", $e); } if ($this->getRequest()->isXmlHttpRequest()) { @@ -288,8 +277,9 @@ class ModuleController extends AbstractCrudController } } catch (\Exception $e) { - \Thelia\Log\Tlog::getInstance()->error(sprintf("error during module removal : %s", $message)); $message = $e->getMessage(); + + Tlog::getInstance()->addError("Error during module removal", $e); } if ($message) {