Working : FileManager :Add some more unit tests

2013-09-24 14:50:42 +02:00
parent 430e18e4e2
commit 71888e68aa
3 changed files with 483 additions and 2 deletions
--- a/core/lib/Thelia/Controller/Admin/FileController.php
+++ b/core/lib/Thelia/Controller/Admin/FileController.php
@@ -107,7 +107,7 @@ class FileController extends BaseAdminController
                    return new ResponseRest($message, 'text', 415);
                }

-                $parentModel = $fileManager->getParentFIleModel($parentType, $parentId);
+                $parentModel = $fileManager->getParentFileModel($parentType, $parentId);
                $imageModel = $fileManager->getImageModel($parentType);

                if ($parentModel === null || $imageModel === null || $fileBeingUploaded === null) {
--- a/core/lib/Thelia/Tests/Tools/FileManagerTest.php
+++ b/core/lib/Thelia/Tests/Tools/FileManagerTest.php
@@ -10,11 +10,18 @@
 namespace Thelia\Tests\Type;


+use Thelia\Core\Event\DocumentCreateOrUpdateEvent;
 use Thelia\Core\Event\ImageCreateOrUpdateEvent;
+use Thelia\Core\Translation\Translator;
 use Thelia\Exception\ImageException;
 use Thelia\Model\Admin;
 use Thelia\Tools\FileManager;

+/**
+ * Class FileManagerTest
+ *
+ * @package Thelia\Tests\Type
+ */
 class FileManagerTest extends \PHPUnit_Framework_TestCase {


@@ -208,6 +215,35 @@ class FileManagerTest extends \PHPUnit_Framework_TestCase {
        $this->assertEquals($expected, $actual);
    }

+    /**
+     * @covers Thelia\Tools\FileManager::saveDocument
+     */
+    public function testSaveDocumentProductDocument()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $stubProductDocument = $this->getMockBuilder('\Thelia\Model\ProductDocument')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $stubProductDocument->expects($this->any())
+            ->method('save')
+            ->will($this->returnValue(10));
+        $stubProductDocument->expects($this->any())
+            ->method('getFile')
+            ->will($this->returnValue('file'));
+
+        $fileManager = new FileManager($stubContainer);
+
+        $event = new DocumentCreateOrUpdateEvent(FileManager::TYPE_PRODUCT, 24);
+
+        $expected = 10;
+        $actual = $fileManager->saveDocument($event, $stubProductDocument);
+
+        $this->assertEquals($expected, $actual);
+    }
+
    /**
     * @covers Thelia\Tools\FileManager::saveImage
     */
@@ -237,6 +273,35 @@ class FileManagerTest extends \PHPUnit_Framework_TestCase {
        $this->assertEquals($expected, $actual);
    }

+    /**
+     * @covers Thelia\Tools\FileManager::saveDocument
+     */
+    public function testSaveDocumentCategoryDocument()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $stubCategoryDocument = $this->getMockBuilder('\Thelia\Model\CategoryDocument')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $stubCategoryDocument->expects($this->any())
+            ->method('save')
+            ->will($this->returnValue(10));
+        $stubCategoryDocument->expects($this->any())
+            ->method('getFile')
+            ->will($this->returnValue('file'));
+
+        $fileManager = new FileManager($stubContainer);
+
+        $event = new DocumentCreateOrUpdateEvent(FileManager::TYPE_CATEGORY, 24);
+
+        $expected = 10;
+        $actual = $fileManager->saveDocument($event, $stubCategoryDocument);
+
+        $this->assertEquals($expected, $actual);
+    }
+
    /**
     * @covers Thelia\Tools\FileManager::saveImage
     */
@@ -266,6 +331,35 @@ class FileManagerTest extends \PHPUnit_Framework_TestCase {
        $this->assertEquals($expected, $actual);
    }

+    /**
+     * @covers Thelia\Tools\FileManager::saveDocument
+     */
+    public function testSaveDocumentFolderDocument()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $stubFolderDocument = $this->getMockBuilder('\Thelia\Model\FolderDocument')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $stubFolderDocument->expects($this->any())
+            ->method('save')
+            ->will($this->returnValue(10));
+        $stubFolderDocument->expects($this->any())
+            ->method('getFile')
+            ->will($this->returnValue('file'));
+
+        $fileManager = new FileManager($stubContainer);
+
+        $event = new DocumentCreateOrUpdateEvent(FileManager::TYPE_FOLDER, 24);
+
+        $expected = 10;
+        $actual = $fileManager->saveDocument($event, $stubFolderDocument);
+
+        $this->assertEquals($expected, $actual);
+    }
+
    /**
     * @covers Thelia\Tools\FileManager::saveImage
     */
@@ -295,6 +389,35 @@ class FileManagerTest extends \PHPUnit_Framework_TestCase {
        $this->assertEquals($expected, $actual);
    }

+    /**
+     * @covers Thelia\Tools\FileManager::saveDocument
+     */
+    public function testSaveDocumentContentDocument()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $stubContentDocument = $this->getMockBuilder('\Thelia\Model\ContentDocument')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $stubContentDocument->expects($this->any())
+            ->method('save')
+            ->will($this->returnValue(10));
+        $stubContentDocument->expects($this->any())
+            ->method('getFile')
+            ->will($this->returnValue('file'));
+
+        $fileManager = new FileManager($stubContainer);
+
+        $event = new DocumentCreateOrUpdateEvent(FileManager::TYPE_CONTENT, 24);
+
+        $expected = 10;
+        $actual = $fileManager->saveDocument($event, $stubContentDocument);
+
+        $this->assertEquals($expected, $actual);
+    }
+
    /**
     * @covers Thelia\Tools\FileManager::saveImage
     * @expectedException \Thelia\Exception\ImageException
@@ -321,6 +444,32 @@ class FileManagerTest extends \PHPUnit_Framework_TestCase {
        $fileManager->saveImage($event, $stubProductImage);
    }

+    /**
+     * @covers Thelia\Tools\FileManager::saveDocument
+     * @expectedException \Thelia\Model\Exception\InvalidArgumentException
+     */
+    public function testSaveDocumentExceptionDocumentException()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $fileManager = new FileManager($stubContainer);
+
+        $stubProductDocument = $this->getMockBuilder('\Thelia\Model\ProductDocument')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $stubProductDocument->expects($this->any())
+            ->method('save')
+            ->will($this->returnValue(10));
+        $stubProductDocument->expects($this->any())
+            ->method('getFile')
+            ->will($this->returnValue('file'));
+
+        $event = new DocumentCreateOrUpdateEvent('bad', 24);
+
+        $fileManager->saveDocument($event, $stubProductDocument);
+    }
+
    /**
     * @covers Thelia\Tools\FileManager::saveImage
     * @expectedException \Thelia\Exception\ImageException
@@ -347,6 +496,32 @@ class FileManagerTest extends \PHPUnit_Framework_TestCase {
        $fileManager->saveImage($event, $stubProductImage);
    }

+    /**
+     * @covers Thelia\Tools\FileManager::saveDocument
+     * @expectedException \Thelia\Model\Exception\InvalidArgumentException
+     */
+    public function testSaveDocumentExceptionDocumentException2()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $fileManager = new FileManager($stubContainer);
+
+        $stubProductDocument = $this->getMockBuilder('\Thelia\Model\ProductDocument')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $stubProductDocument->expects($this->any())
+            ->method('save')
+            ->will($this->returnValue(0));
+        $stubProductDocument->expects($this->any())
+            ->method('getFile')
+            ->will($this->returnValue('file'));
+
+        $event = new DocumentCreateOrUpdateEvent(FileManager::TYPE_PRODUCT, 24);
+
+        $fileManager->saveDocument($event, $stubProductDocument);
+    }
+
    /**
     * @covers Thelia\Tools\FileManager::sanitizeFileName
     */
@@ -365,6 +540,301 @@ class FileManagerTest extends \PHPUnit_Framework_TestCase {
        $this->assertEquals($expected, $actual);
    }

+    /**
+     * @covers Thelia\Tools\FileManager::getImageModel
+     */
+    public function testGetImageModel()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $fileManager = new FileManager($stubContainer);
+        $actual = $fileManager->getImageModel(FileManager::TYPE_PRODUCT);
+        $this->assertInstanceOf('\Thelia\Model\ProductImage', $actual);
+        $actual = $fileManager->getImageModel(FileManager::TYPE_CATEGORY);
+        $this->assertInstanceOf('\Thelia\Model\CategoryImage', $actual);
+        $actual = $fileManager->getImageModel(FileManager::TYPE_CONTENT);
+        $this->assertInstanceOf('\Thelia\Model\ContentImage', $actual);
+        $actual = $fileManager->getImageModel(FileManager::TYPE_FOLDER);
+        $this->assertInstanceOf('\Thelia\Model\FolderImage', $actual);
+        $actual = $fileManager->getImageModel('bad');
+        $this->assertNull($actual);
+    }
+
+    /**
+     * @covers Thelia\Tools\FileManager::getDocumentModel
+     */
+    public function testGetDocumentModel()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $fileManager = new FileManager($stubContainer);
+        $actual = $fileManager->getDocumentModel(FileManager::TYPE_PRODUCT);
+        $this->assertInstanceOf('\Thelia\Model\ProductDocument', $actual);
+        $actual = $fileManager->getDocumentModel(FileManager::TYPE_CATEGORY);
+        $this->assertInstanceOf('\Thelia\Model\CategoryDocument', $actual);
+        $actual = $fileManager->getDocumentModel(FileManager::TYPE_CONTENT);
+        $this->assertInstanceOf('\Thelia\Model\ContentDocument', $actual);
+        $actual = $fileManager->getDocumentModel(FileManager::TYPE_FOLDER);
+        $this->assertInstanceOf('\Thelia\Model\FolderDocument', $actual);
+        $actual = $fileManager->getDocumentModel('bad');
+        $this->assertNull($actual);
+    }
+
+    /**
+     * @covers Thelia\Tools\FileManager::getImageModelQuery
+     */
+    public function testGetImageModelQuery()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $fileManager = new FileManager($stubContainer);
+        $actual = $fileManager->getImageModelQuery(FileManager::TYPE_PRODUCT);
+        $this->assertInstanceOf('\Thelia\Model\ProductImageQuery', $actual);
+        $actual = $fileManager->getImageModelQuery(FileManager::TYPE_CATEGORY);
+        $this->assertInstanceOf('\Thelia\Model\CategoryImageQuery', $actual);
+        $actual = $fileManager->getImageModelQuery(FileManager::TYPE_CONTENT);
+        $this->assertInstanceOf('\Thelia\Model\ContentImageQuery', $actual);
+        $actual = $fileManager->getImageModelQuery(FileManager::TYPE_FOLDER);
+        $this->assertInstanceOf('\Thelia\Model\FolderImageQuery', $actual);
+        $actual = $fileManager->getImageModelQuery('bad');
+        $this->assertNull($actual);
+    }
+
+    /**
+     * @covers Thelia\Tools\FileManager::getDocumentModelQuery
+     */
+    public function testGetDocumentModelQuery()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $fileManager = new FileManager($stubContainer);
+        $actual = $fileManager->getDocumentModelQuery(FileManager::TYPE_PRODUCT);
+        $this->assertInstanceOf('\Thelia\Model\ProductDocumentQuery', $actual);
+        $actual = $fileManager->getDocumentModelQuery(FileManager::TYPE_CATEGORY);
+        $this->assertInstanceOf('\Thelia\Model\CategoryDocumentQuery', $actual);
+        $actual = $fileManager->getDocumentModelQuery(FileManager::TYPE_CONTENT);
+        $this->assertInstanceOf('\Thelia\Model\ContentDocumentQuery', $actual);
+        $actual = $fileManager->getDocumentModelQuery(FileManager::TYPE_FOLDER);
+        $this->assertInstanceOf('\Thelia\Model\FolderDocumentQuery', $actual);
+        $actual = $fileManager->getDocumentModelQuery('bad');
+        $this->assertNull($actual);
+    }
+
+    /**
+     * @covers Thelia\Tools\FileManager::getParentFileModel
+     */
+    public function testGetParentFileModel()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $fileManager = new FileManager($stubContainer);
+        $actual = $fileManager->getParentFileModel(FileManager::TYPE_PRODUCT, 1);
+        $this->assertInstanceOf('\Thelia\Model\Product', $actual);
+        $actual = $fileManager->getParentFileModel(FileManager::TYPE_CATEGORY, 1);
+        $this->assertInstanceOf('\Thelia\Model\Category', $actual);
+        $actual = $fileManager->getParentFileModel(FileManager::TYPE_CONTENT, 1);
+        $this->assertInstanceOf('\Thelia\Model\Content', $actual);
+        $actual = $fileManager->getParentFileModel(FileManager::TYPE_FOLDER, 1);
+        $this->assertInstanceOf('\Thelia\Model\Folder', $actual, 1);
+        $actual = $fileManager->getParentFileModel('bad', 1);
+        $this->assertNull($actual);
+    }
+
+    /**
+     * @covers Thelia\Tools\FileManager::getImageForm
+     */
+    public function testGetImageForm()
+    {
+        // Mock issue
+        $this->markTestIncomplete(
+            'This test has not been implemented yet.'
+        );
+    }
+    /**
+     * @covers Thelia\Tools\FileManager::getDocumentForm
+     */
+    public function testGetDocumentForm()
+    {
+        // Mock issue
+        $this->markTestIncomplete(
+            'This test has not been implemented yet.'
+        );
+    }
+
+    /**
+     * @covers Thelia\Tools\FileManager::getUploadDir
+     */
+    public function testGetUploadDir()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $fileManager = new FileManager($stubContainer);
+
+        $actual = $fileManager->getUploadDir(FileManager::TYPE_PRODUCT, FileManager::FILE_TYPE_IMAGES);
+        $this->assertEquals(THELIA_LOCAL_DIR . 'media/images/product', $actual);
+        $actual = $fileManager->getUploadDir(FileManager::TYPE_CATEGORY, FileManager::FILE_TYPE_IMAGES);
+        $this->assertEquals(THELIA_LOCAL_DIR . 'media/images/category', $actual);
+        $actual = $fileManager->getUploadDir(FileManager::TYPE_CONTENT, FileManager::FILE_TYPE_IMAGES);
+        $this->assertEquals(THELIA_LOCAL_DIR . 'media/images/content', $actual);
+        $actual = $fileManager->getUploadDir(FileManager::TYPE_FOLDER, FileManager::FILE_TYPE_IMAGES);
+        $this->assertEquals(THELIA_LOCAL_DIR . 'media/images/folder', $actual);
+        $actual = $fileManager->getUploadDir('bad', FileManager::FILE_TYPE_IMAGES);
+        $this->assertEquals(false, $actual);
+
+        $actual = $fileManager->getUploadDir(FileManager::TYPE_PRODUCT, FileManager::FILE_TYPE_DOCUMENTS);
+        $this->assertEquals(THELIA_LOCAL_DIR . 'media/documents/product', $actual);
+        $actual = $fileManager->getUploadDir(FileManager::TYPE_CATEGORY, FileManager::FILE_TYPE_DOCUMENTS);
+        $this->assertEquals(THELIA_LOCAL_DIR . 'media/documents/category', $actual);
+        $actual = $fileManager->getUploadDir(FileManager::TYPE_CONTENT, FileManager::FILE_TYPE_DOCUMENTS);
+        $this->assertEquals(THELIA_LOCAL_DIR . 'media/documents/content', $actual);
+        $actual = $fileManager->getUploadDir(FileManager::TYPE_FOLDER, FileManager::FILE_TYPE_DOCUMENTS);
+        $this->assertEquals(THELIA_LOCAL_DIR . 'media/documents/folder', $actual);
+        $actual = $fileManager->getUploadDir('bad', FileManager::FILE_TYPE_DOCUMENTS);
+        $this->assertEquals(false, $actual);
+
+        $actual = $fileManager->getUploadDir(FileManager::TYPE_FOLDER, 'bad');
+        $this->assertEquals(false, $actual);
+    }
+
+    /**
+     * @covers Thelia\Tools\FileManager::getRedirectionUrl
+     */
+    public function testGetRedirectionUrl()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $fileManager = new FileManager($stubContainer);
+
+        $actual = $fileManager->getRedirectionUrl(FileManager::TYPE_PRODUCT, 1);
+        $this->assertEquals('/admin/products/update?product_id=1&current_tab=images', $actual);
+        $actual = $fileManager->getRedirectionUrl(FileManager::TYPE_CATEGORY, 1);
+        $this->assertEquals('/admin/categories/update?category_id=1&current_tab=images', $actual);
+        $actual = $fileManager->getRedirectionUrl(FileManager::TYPE_CONTENT, 1);
+        $this->assertEquals('/admin/content/update/1&current_tab=images', $actual);
+        $actual = $fileManager->getRedirectionUrl(FileManager::TYPE_FOLDER, 1);
+        $this->assertEquals('/admin/folders/update/1&current_tab=images', $actual);
+        $actual = $fileManager->getRedirectionUrl('bad', 1);
+        $this->assertEquals(false, $actual);
+    }
+
+
+    /**
+     * @covers Thelia\Tools\FileManager::renameFile
+     */
+    public function testRenameFile()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $stubUploadedFile = $this->getMockBuilder('\Symfony\Component\HttpFoundation\File\UploadedFile')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $stubUploadedFile->expects($this->any())
+            ->method('getClientOriginalExtension')
+            ->will($this->returnValue('yml'));
+        $stubUploadedFile->expects($this->any())
+            ->method('getClientOriginalName')
+            ->will($this->returnValue('or1-g_n?al*/&é"filen@me#'));
+
+
+        $fileManager = new FileManager($stubContainer);
+
+        $expected = 'or1-g_nalyfilenme-1.yml';
+        $actual = $fileManager->renameFile(1, $stubUploadedFile);
+
+        $this->assertEquals($expected, $actual);
+    }
+
+    /**
+     * @covers Thelia\Tools\FileManager::renameFile
+     */
+    public function testRenameFileWithoutExtension()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $stubUploadedFile = $this->getMockBuilder('\Symfony\Component\HttpFoundation\File\UploadedFile')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $stubUploadedFile->expects($this->any())
+            ->method('getClientOriginalExtension')
+            ->will($this->returnValue(''));
+        $stubUploadedFile->expects($this->any())
+            ->method('getClientOriginalName')
+            ->will($this->returnValue('or1-g_n?al*/&é"filen@me#'));
+
+
+        $fileManager = new FileManager($stubContainer);
+
+        $expected = 'or1-g_nalyfilenme-1';
+        $actual = $fileManager->renameFile(1, $stubUploadedFile);
+
+        $this->assertEquals($expected, $actual);
+    }
+
+    /**
+     * @covers Thelia\Tools\FileManager::isImage
+     */
+    public function testIsImage()
+    {
+        $stubContainer = $this->getMockBuilder('\Symfony\Component\DependencyInjection\ContainerInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $fileManager = new FileManager($stubContainer);
+
+        $actual = $fileManager->isImage('image/jpeg');
+        $this->assertTrue($actual);
+        $actual = $fileManager->isImage('image/png');
+        $this->assertTrue($actual);
+        $actual = $fileManager->isImage('image/gif');
+        $this->assertTrue($actual);
+
+        $actual = $fileManager->isImage('bad');
+        $this->assertFalse($actual);
+        $actual = $fileManager->isImage('image/jpg');
+        $this->assertFalse($actual);
+        $actual = $fileManager->isImage('application/x-msdownload');
+        $this->assertFalse($actual);
+        $actual = $fileManager->isImage('application/x-sh');
+        $this->assertFalse($actual);
+
+    }
+
+
+    /**
+     * @covers Thelia\Tools\FileManager::getAvailableTypes
+     */
+    public function testGetAvailableTypes()
+    {
+        $expected = array(
+            FileManager::TYPE_CATEGORY,
+            FileManager::TYPE_CONTENT,
+            FileManager::TYPE_FOLDER,
+            FileManager::TYPE_PRODUCT,
+            FileManager::TYPE_MODULE,
+        );
+        $actual = FileManager::getAvailableTypes();
+
+        $this->assertEquals($expected, $actual);
+    }
+
    /**
     * @covers Thelia\Tools\FileManager::adminLogAppend
     */
@@ -374,4 +844,15 @@ class FileManagerTest extends \PHPUnit_Framework_TestCase {
            'This test has not been implemented yet.'
        );
    }
+
+    /**
+     * @covers Thelia\Tools\FileManager::deleteFile
+     */
+    public function testDeleteFile()
+    {
+        // @todo see http://tech.vg.no/2011/03/09/mocking-the-file-system-using-phpunit-and-vfsstream/
+        $this->markTestIncomplete(
+            'This test has not been implemented yet.'
+        );
+    }
 }
--- a/core/lib/Thelia/Tools/FileManager.php
+++ b/core/lib/Thelia/Tools/FileManager.php
@@ -453,7 +453,7 @@ class FileManager
     *
     * @todo refactor make all pictures using propel inheritance and factorise image behaviour into one single clean action
     */
-    public function getParentFIleModel($parentType, $parentId)
+    public function getParentFileModel($parentType, $parentId)
    {
        switch ($parentType) {
            case self::TYPE_PRODUCT: