fix payment and delivery form. Fix #434

core/lib/Thelia/Core/Template/Loop/Content.php

@@ -60,7 +60,20 @@ class Content extends BaseI18nLoop implements PropelSearchLoopInterface
             new Argument(
                 'order',
                 new TypeCollection(
-                    new Type\EnumListType(array('alpha', 'alpha-reverse', 'manual', 'manual_reverse', 'random', 'given_id', 'created', 'created_reverse', 'updated', 'updated_reverse'))
+                    new Type\EnumListType(
+                        array(
+                            'alpha',
+                            'alpha-reverse',
+                            'manual',
+                            'manual_reverse',
+                            'random',
+                            'given_id',
+                            'created',
+                            'created_reverse',
+                            'updated',
+                            'updated_reverse'
+                        )
+                    )
                 ),
                 'alpha'
             ),

core/lib/Thelia/Form/OrderDelivery.php

@@ -66,19 +66,15 @@ class OrderDelivery extends BaseForm
     public function verifyDeliveryModule($value, ExecutionContextInterface $context)
     {
         $module = ModuleQuery::create()
-            ->filterByType(BaseModule::DELIVERY_MODULE_TYPE)
-            ->filterByActivate(1)
-            ->filterById($value)
+            ->filterActivatedByTypeAndId(BaseModule::DELIVERY_MODULE_TYPE, $value)
             ->findOne();
 
         if (null === $module) {
             $context->addViolation(Translator::getInstance()->trans("Delivery module ID not found"));
-        } else {
-            if (! $module->isDeliveryModule()) {
-                $context->addViolation(
-                    sprintf(Translator::getInstance()->trans("delivery module %s is not a Thelia\Module\DeliveryModuleInterface"), $module->getCode())
-                );
-            }
+        } elseif (! $module->isDeliveryModule()) {
+            $context->addViolation(
+                sprintf(Translator::getInstance()->trans("delivery module %s is not a Thelia\Module\DeliveryModuleInterface"), $module->getCode())
+            );
         }
     }
 

core/lib/Thelia/Form/OrderPayment.php

@@ -66,16 +66,12 @@ class OrderPayment extends BaseForm
     public function verifyPaymentModule($value, ExecutionContextInterface $context)
     {
         $module = ModuleQuery::create()
-            ->filterByType(BaseModule::PAYMENT_MODULE_TYPE)
-            ->filterByActivate(1)
-            ->filterById($value)
+            ->filterActivatedByTypeAndId(BaseModule::PAYMENT_MODULE_TYPE, $value)
             ->findOne();
 
         if (null === $module) {
             $context->addViolation("Payment module ID not found");
-        }
-
-        if (! $module->isPayementModule()) {
+        } elseif (! $module->isPayementModule()) {
             $context->addViolation(
                 sprintf(Translator::getInstance()->trans("payment module %s is not a Thelia\Module\PaymentModuleInterface"), $module->getCode())
             );

core/lib/Thelia/Model/ModuleQuery.php

@@ -3,6 +3,7 @@
 namespace Thelia\Model;
 
 use Thelia\Model\Base\ModuleQuery as BaseModuleQuery;
+use Thelia\Module\BaseModule;
 
 /**
  * Skeleton subclass for performing query and update operations on the 'module' table.
@@ -24,7 +25,7 @@ class ModuleQuery extends BaseModuleQuery
     {
         if (null === self::$activated) {
             self::$activated = self::create()
-                ->filterByActivate(1)
+                ->filterByActivate(BaseModule::IS_ACTIVATED)
                 ->orderByPosition()
                 ->find();
         }
@@ -37,4 +38,17 @@ class ModuleQuery extends BaseModuleQuery
         self::$activated = null;
     }
 
+    /**
+     * @param int $moduleType the module type : classic, payment or delivery. Use BaseModule constant here.
+     * @param int $id the module id
+     * @return ModuleQuery
+     */
+    public function filterActivatedByTypeAndId($moduleType, $id)
+    {
+        return $this
+            ->filterByType($moduleType)
+            ->filterByActivate(BaseModule::IS_ACTIVATED)
+            ->filterById($id);
+    }
+
 } // ModuleQuery